src: use spaceship operator in SocketAddress #56059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
approved these changes
Nov 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56059 +/- ##
==========================================
- Coverage 87.96% 87.95% -0.01%
==========================================
Files 656 656
Lines 188384 188387 +3
Branches 35968 35979 +11
==========================================
- Hits 165707 165698 -9
- Misses 15845 15846 +1
- Partials 6832 6843 +11
|
jasnell
added a commit
that referenced
this pull request
Dec 3, 2024
PR-URL: #56059 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
Landed in b915124 |
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
PR-URL: nodejs#56059 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
PR-URL: nodejs#56059 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor cleanups. There's a lot more than can be cleaned up / improved in this class but just starting small and incremental